fix(get-function-name-with-kind): fix default exported function name #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelDeBoey
changed the title
MichaelDeBoey
changed the title
Codecov ReportBase: 96.01% // Head: 96.03% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
+ Coverage 96.01% 96.03% +0.01%
==========================================
Files 13 13
Lines 653 655 +2
==========================================
+ Hits 627 629 +2
Misses 26 26
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Without the fix, added tests were failing like: 1) The 'getFunctionNameWithKind' function
should return "async generator function 'default'" for "export default async function* () {}".:
AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected
+ 'async generator function'
- "async generator function 'default'"
+ expected - actual
-async generator function
+async generator function 'default'
at Context.<anonymous> (test/get-function-name-with-kind.js:159:20)
at processImmediate (node:internal/timers:464:21)
2) The 'getFunctionNameWithKind' function
should return "async generator function 'default'" for "export default async function* () {}" if sourceCode is present.:
AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected
+ 'async generator function'
- "async generator function 'default'"
+ expected - actual
-async generator function
+async generator function 'default'
at Context.<anonymous> (test/get-function-name-with-kind.js:189:20)
at processImmediate (node:internal/timers:464:21)
3) The 'getFunctionNameWithKind' function
should return "async arrow function 'default'" for "export default async () => {}".:
AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected
+ 'async arrow function'
- "async arrow function 'default'"
+ expected - actual
-async arrow function
+async arrow function 'default'
at Context.<anonymous> (test/get-function-name-with-kind.js:159:20)
at processImmediate (node:internal/timers:464:21)
4) The 'getFunctionNameWithKind' function
should return "async arrow function 'default'" for "export default async () => {}" if sourceCode is present.:
AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
+ actual - expected
+ 'async arrow function'
- "async arrow function 'default'"
+ expected - actual
-async arrow function
+async arrow function 'default' |
|
🎉 This PR is included in version 4.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mysticatea#24