Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing tsconfig option #2

Open
quansenB opened this issue Apr 1, 2020 · 1 comment
Open

Missing tsconfig option #2

quansenB opened this issue Apr 1, 2020 · 1 comment

Comments

@quansenB
Copy link

quansenB commented Apr 1, 2020 •
edited
Loading

Not sure, why I can not open a PR here.

Anyway, I stubled across a small bug that occurs when the nodes dir contains only one file and the credentials is empty. This is the case for alternative custom nodes using the same creds as the "normal" version.

"rootDir": "./", is needed to preserve the directory structure when building.

Related: microsoft/TypeScript#5134 (comment)

I also recommend adding a "release": "npm run build && npm publish" script
@pestevez
Copy link

pestevez commented May 4, 2020

Thanks for the info, @quansenB. I added the rootDir item to the compilerOptions element and it maintained the structure, as you describe.

Are you trying to open the PR here from a fork or from this repo directly? The latter should work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pestevez @quansenB