Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poorly written, broken English clause for SplitInBatches' "Reset" help tooltip #12420

Open
jerzygangi opened this issue Jan 1, 2025 · 2 comments
Labels
in linear Issue or PR has been created in Linear for internal review

Comments

@jerzygangi
Copy link

jerzygangi commented Jan 1, 2025

Bug Description

The SplitInBatches node1 has an option called "Reset." When you hover over the help tooltip for "Reset," n8n shows this clause:

"Whether the node will be reset and so with the current input-data newly initialized" (source)

This is poorly written, broken English and needs to be improved. Specifically:

  1. "...the node will be reset and so with..." is not syntatically correct English.
  2. "input-data" shouldn't be hypenated.
  3. The clause doesn't make sense.
  4. The clause doesn't explain what the "Reset" feature does.

It seems this bug may be partially attributed to @janober in 89a73d4 ("Make it possible to reste [sic] SplitInBatches-Node"), and partially attributed to @michael-radency and @ivov in 88dea33 (via n8n-nodes-base/node-param-description-boolean-without-whether).

I'd love to know what the "Reset" feature does, and I imagine other n8n users would, too. If someone could rewrite the help text for "Reset" to be a cogent English clause, that would be great. Thanks!

To Reproduce

  1. Open the SplitInBatches node in n8n.
  2. Hover over the "Reset" option's tooltip.

Expected behavior

The "Reset" tooltip is a helpful, cogent English clause.

Operating System

Irrelevant

n8n Version

Irrelevant

Node.js Version

Irrelevant

Database

Irrelevant

Execution mode

Irrelevant

Footnotes

  1. This bug applies to all versions of the SplitInBatches node.

@Joffcom
Copy link
Member

Joffcom commented Jan 1, 2025

Hey @jerzygangi

Thanks for spotting that I will get it updated, to get things started...

If it’s turned on, the node will start fresh with new data every time it loops around.

@Joffcom
Copy link
Member

Joffcom commented Jan 2, 2025

Hey @jerzygangi,

We have created an internal ticket to look into this which we will be tracking as "N8N-8030"

@Joffcom Joffcom added the in linear Issue or PR has been created in Linear for internal review label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in linear Issue or PR has been created in Linear for internal review
Projects
None yet
Development

No branches or pull requests

2 participants