Very slow start up of Naemon if a system has many downtimes

[nook24]

Hi,

I found an issue within Naemon which will occur as soon as the system has to handle thousands of downtimes. In this case a restart of Naemon takes more than 15 minutes.

# cat retention.dat | grep hostdowntime | wc -l
21127

# cat retention.dat | grep servicedowntime | wc -l
294420

The issue is caused by the find_comment function

naemon-core/src/naemon/comments.c

Lines 640 to 650 in 4700219

	comment *find_comment(unsigned long comment_id, int comment_type)
	{
	comment *temp_comment = NULL;
	for (temp_comment = comment_list; temp_comment != NULL; temp_comment = temp_comment->next) {
	if (temp_comment->comment_id == comment_id && (temp_comment->comment_type & comment_type))
	return temp_comment;
	}
	return NULL;
	}

My suggestion is to replace this with an hashmap.

[nook24]

I guess this will be resolved with #440 ?@sni

[sni]

that's right.