Muting the master of a multi-room group does not seem to work

[akloeckner]

If I have a group of players in a multi-room group, I cannot mute the master. I can, however, mute any slave. And I can also mute the device, if it is not grouped in multi-room mode.

I wonder, if this the root of the issue:

home-assistant-custom-components-linkplay/custom_components/linkplay/media_player.py

Lines 1686 to 1689 in c2cdac8

	if self._is_master:
	value = await self.call_linkplay_httpapi("setPlayerCmd:slave_mute:{0}".format(str(int(mute))), None)
	else:
	value = await self.call_linkplay_httpapi("setPlayerCmd:mute:{0}".format(str(int(mute))), None)

Why would the master need to be muted using a slave command?

If I use the non-slave command manually (by opening http://wohnzimmer-arylic/httpapi.asp?command=setPlayerCmd:mute:1) it works as expected.

[akloeckner]

I found the commit introducing this piece of code: 2f748c9 , line 562. Maybe it helps getting to grips with it. Unfortunately, I don't see why this was introduced...

[akloeckner]

@nagyrobi, while researching another issue, I have found some more pieces of code, that do not make sense (at least to me). Would you support me in reviewing and merging some code improvements? I would then use some of my spare time to polish up this component. This might very well also contain some refactoring, e.g. I have found a few (at least seemingly) redundant multiroom-variables.

[nagyrobi]

Until the end of this year, it's very unlikely that I will have any spare time for this.

[akloeckner]

Ok, thanks for being so frank! I think, I'll try and fix things on my own fork then, while they occur. We can always start to merge things back. Just let me know.