Trusted key adding / removal via updates #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristapsk
force-pushed
the
key-rotation
branch
from
c5e0d83 to
775a247
Compare
x1ddos
reviewed
Jan 15, 2025
| @@ -0,0 +1,26 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
i'm not sure bash is always present on the system. when i started with a minimal version, had only sh and dash. the latter is usually aliased to "bash". would recommend to switch to /bin/sh like in other scripts.
There was a problem hiding this comment.
On current image used there is bash. Will check this with fresh Void image. Then need to double check it works there, as I have tested this only with bash currently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now after new updates are pulled from git, contents of keys directory is analyzed. Any keys not present there anymore will be deleted from GPG keychain and any new keys will be added.
Resolves #4.