Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests failure #45

Open
nalimilan opened this issue Feb 17, 2020 · 0 comments · May be fixed by #46
Open

Fix tests failure #45

nalimilan opened this issue Feb 17, 2020 · 0 comments · May be fixed by #46

Comments

@nalimilan
Copy link
Owner

See https://github.com/nalimilan/FreqTables.jl/pull/44/files#r379828525.

Reproducer:

using NamedArrays, CategoricalArrays
NamedArray(ones(3, 2), (["a", "b", "c"], Vector(categorical([true, false]))), ("A", "B"))[1:2,:]

This is a corner case which happens when passing a Vector{<:CategoricalValue}, which gets converted to a CategoricalVector on indexing, which apparently isn't supported by NamedArrays. This only happens when crossing categorical and non categorical variables. The code should unwrap the values.

This was referenced Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant