You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We ask new contributors to follow the rules for writing commit messages, but there is nothing in CONTRIBUTING.md about commit messages.
Because there are no explicit rules for writing commits, we believe that contributors who are familiar with CONTRIBUTING.md rules from other open source projects may be confused when they first want to contribute to uftrace.
Therefore, we propose to explicitly mention in CONTRIBUTING.md the rules to follow when writing commit messages, as in several other open source projects [1, 2], and to use commitlint as mentioned in a previous PR Comment: #1810 (comment).
Thanks for the heads up @gichoel! I think having the commit message guide in CONTRIBUTING.md will be helpful. And having commitlint as a pre-commit hook will also be very useful as well.
We ask new contributors to follow the rules for writing commit messages, but there is nothing in
CONTRIBUTING.md
about commit messages.Because there are no explicit rules for writing commits, we believe that contributors who are familiar with
CONTRIBUTING.md
rules from other open source projects may be confused when they first want to contribute to uftrace.Therefore, we propose to explicitly mention in
CONTRIBUTING.md
the rules to follow when writing commit messages, as in several other open source projects [1, 2], and to usecommitlint
as mentioned in a previous PR Comment: #1810 (comment).[1]. https://github.com/rapid7/metasploit-framework/blob/master/CONTRIBUTING.md#pull-requests
[2]. https://github.com/openbmc/docs/blob/master/CONTRIBUTING.md#formatting-commit-messages
The text was updated successfully, but these errors were encountered: