Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect PIC ports used in kernel #52

Open
ParfenovIgor opened this issue Mar 29, 2024 · 0 comments
Open

Incorrect PIC ports used in kernel #52

ParfenovIgor opened this issue Mar 29, 2024 · 0 comments

Comments

@ParfenovIgor
Copy link

In file /src/kernel/arch/i686/i8259.c

Line 136:

return ((uint16_t)i686_inb(PIC2_COMMAND_PORT)) | (((uint16_t)i686_inb(PIC2_COMMAND_PORT)) << 8);

I am not sure, but doesn't it have to be:

return ((uint16_t)i686_inb(PIC1_COMMAND_PORT)) | (((uint16_t)i686_inb(PIC2_COMMAND_PORT)) << 8);

The same issue on line 143.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ParfenovIgor