Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility for TI target build paths #2832

Merged
merged 7 commits into from
Dec 21, 2023
Merged

Conversation

networkfusion
Copy link
Member

@networkfusion networkfusion commented Nov 16, 2023

Description

Fixes ability to build when path includes multiple occurences of "/bin"

Motivation and Context

Fixes bulids for TI targets when using certain paths.

How Has This Been Tested?

  • azure-pipeline still able to build target.
  • docker containers can now build target.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dev Containers (changes related with Dev Containers, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

Fixes ability to build when path includes multiple occurences of "/bin"
@networkfusion
Copy link
Member Author

@josesimoes please can you try this on your local windows instance to confirm the fix is still compatible.

@networkfusion
Copy link
Member Author

networkfusion commented Nov 16, 2023

current pipeline failures are unrelated (chibios download). jobs re-ran.

@networkfusion networkfusion mentioned this pull request Nov 16, 2023
13 tasks
@networkfusion networkfusion changed the title Fix paths for TI Fix compatibility for TI target build paths Nov 16, 2023
@networkfusion networkfusion mentioned this pull request Dec 21, 2023
13 tasks
@networkfusion networkfusion merged commit deaefb4 into main Dec 21, 2023
19 of 31 checks passed
@networkfusion networkfusion deleted the networkfusion-ti-patch branch December 21, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants