Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Add Email Authentication] verify emails using otp/passwordless sign in #520

Open
narayan954 opened this issue Jun 22, 2023 · 30 comments
Open
Assignees

Comments

@narayan954
Copy link
Owner

Description

firebase provides inbuilt support for email verification
We can implement this for our application. There're several guides for this as well around the web.

Screenshots

No response

Additional information

I'm enabling email sign in and this'd secure/authenticate the signups

@narayan954
Copy link
Owner Author

I've enabled this for the production so you can test without the need for generating your own creds
image

@narayan954 narayan954 added level3 and removed level3 labels Jun 22, 2023
@marshadkhn
Copy link

Hey @narayan954 I know firebase well worked for 4 month on that
Assign me this issue

@narayan954
Copy link
Owner Author

Hey @narayan954 I know firebase well worked for 4 month on that Assign me this issue

Cool!, best of luck!

@marshadkhn
Copy link

Thankyou @narayan954
Soon I will send the PR!

@narayan954
Copy link
Owner Author

@marshadkhn are you working on this???

@narayan954 narayan954 pinned this issue Jul 10, 2023
@narayan954
Copy link
Owner Author

Actually this is a priority issue, so am pinning it, else I'll work on this

@marshadkhn
Copy link

Yes i will send pr tomorrow for sure

@narayan954
Copy link
Owner Author

Yes i will send pr tomorrow for sure

oh okay thanks!

@marshadkhn
Copy link

verification by link will be valid or it's important to get one-time-password on email?

@Palakkgoyal
Copy link
Contributor

Hey @narayan954 Can I work on this?

@narayan954
Copy link
Owner Author

verification by link will be valid or it's important to get one-time-password on email?

anyone shall do! we are just verifying :)

@narayan954
Copy link
Owner Author

Hey @narayan954 Can I work on this?

I think perhaps he's working on this, let's wait :)

@Palakkgoyal
Copy link
Contributor

But he is not replying

@marshadkhn
Copy link

I will push today

@marshadkhn
Copy link

Suffering from health condition the code will be pushed today

@Palakkgoyal
Copy link
Contributor

Suffering from health condition the code will be pushed today

Sorry to hear that.

@marshadkhn
Copy link

Yes

@narayan954
Copy link
Owner Author

Suffering from health condition the code will be pushed today

get well soon broo, health first priority!

@Palakkgoyal
Copy link
Contributor

Exactly.

@narayan954
Copy link
Owner Author

Yes

Hi @marshadkhn this is a priority issue now, can you please raise the pr by tonight? (5 Aug) else either me or @Palakkgoyal can work on this.

@fahaad-abbadi
Copy link

Can I work on this? I previously worked on private routing thing in ReactJS using firebase, in addition to that, I also worked on the OCR thing using firebase in android.

@narayan954
Copy link
Owner Author

Can I work on this? I previously worked on private routing thing in ReactJS using firebase, in addition to that, I also worked on the OCR thing using firebase in android.

Yeah sure, you can work on this :)
Let me know and I'll enable the email sign in feature in firebase dashboard

@fahaad-abbadi
Copy link

Hi,

Can I work on this? I previously worked on private routing thing in ReactJS using firebase, in addition to that, I also worked on the OCR thing using firebase in android.

Yeah sure, you can work on this :) Let me know and I'll enable the email sign in feature in firebase dashboard

Okay, from today I'll start

@narayan954
Copy link
Owner Author

narayan954 commented Sep 18, 2023

Hi,

Can I work on this? I previously worked on private routing thing in ReactJS using firebase, in addition to that, I also worked on the OCR thing using firebase in android.

Yeah sure, you can work on this :) Let me know and I'll enable the email sign in feature in firebase dashboard

Okay, from today I'll start

best of luck, I've enabled the feature :)

@fahaad-abbadi
Copy link

    if (!error.email && userDatails.email !== "") {
      const actionCodeSettings = {
        url: `${window.location.origin}/dummygram`, // URL where the link will redirect
        handleCodeInApp: true,
      };

Hey, I'm trying to get this, but when I click the link, it redirects me to the same sign in page. IDK why? Could it be the issue with the authorization?

@fahaad-abbadi
Copy link

Also, can you check in

Authentication -> settings -> Authorized Domains and see whether localhost is added or not

@narayan954
Copy link
Owner Author

Also, can you check in

Authentication -> settings -> Authorized Domains and see whether localhost is added or not

sorry I missed the comment.
Yes, localhost's there.

@narayan954
Copy link
Owner Author

narayan954 commented Sep 30, 2023

    if (!error.email && userDatails.email !== "") {
      const actionCodeSettings = {
        url: `${window.location.origin}/dummygram`, // URL where the link will redirect
        handleCodeInApp: true,
      };

Hey, I'm trying to get this, but when I click the link, it redirects me to the same sign in page. IDK why? Could it be the issue with the authorization?

seems like an auth issue, as we have a function to redirect to sign in page if theres no authuser
image
there's a property in user object isemailverified. I think that might help.
Will look into this more asap

@GauravGupta993
Copy link

I would like to work on this issue. Please assign this issue to me.

@narayan954
Copy link
Owner Author

I would like to work on this issue. Please assign this issue to me.

Sure, go ahead! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

5 participants