Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert command success events to INFORMATION type #114

Closed
2 tasks done
thnkslprpt opened this issue Jan 17, 2024 · 0 comments · Fixed by #115
Closed
2 tasks done

Convert command success events to INFORMATION type #114

thnkslprpt opened this issue Jan 17, 2024 · 0 comments · Fixed by #115

Comments

@thnkslprpt
Copy link
Contributor

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
Similar to DS issue 107
FM is out-of-family with most of cFS in declaring successful command EIDs as DEBUG type, and also not in line with the cFE Developer's Guide s7.2. See additional reasoning here which makes a lot of sense.

Code snips

FM/fsw/inc/fm_events.h

Lines 304 to 313 in 4c8c383

* \brief FM Move File Command Event ID
*
* \par Type: DEBUG
*
* \par Cause
*
* This event message signals the successful completion of a
* /FM_Move command.
*/
#define FM_MOVE_CMD_EID 20

FM/fsw/inc/fm_events.h

Lines 358 to 367 in 4c8c383

* \brief FM Rename File Command Event ID
*
* \par Type: DEBUG
*
* \par Cause
*
* This event message signals the successful completion of a
* /FM_Rename command.
*/
#define FM_RENAME_CMD_EID 24

FM/fsw/inc/fm_events.h

Lines 412 to 421 in 4c8c383

* \brief FM Delete File Command Event ID
*
* \par Type: DEBUG
*
* \par Cause
*
* This event message signals the successful completion of a
* /FM_Delete command.
*/
#define FM_DELETE_CMD_EID 28

etc...
(~20 cases total)

Expected behavior
Successful/nominal command events should be defined as INFO type.

Reporter Info
Avi Weiss   @thnkslprpt

thnkslprpt added a commit to thnkslprpt/FM that referenced this issue Jan 17, 2024
dzbaker added a commit that referenced this issue Jan 25, 2024
…s-events-as-INFO

Fix #114, Convert command success events to `INFORMATION` type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant