Are all dependencies really needed?

[auterium]

Hello there :)

I started looking at the code and something quickly caught my eye: there seem to be room for improvement in the dependencies.

Chrono

This is included in the coinbase sub-crate but never used in the code. I see it's used in binance sub-crate only to get the timestamp in milliseconds. This can be achieved also with the std library:

use std::time::SystemTime;

fn main() {
    let ts = SystemTime::now().duration_since(SystemTime::UNIX_EPOCH).unwrap().as_millis();
    println!("{}", ts);
}

Reqwest: blocking

Using reqwest with the blocking feature will block the entire thread while waiting for the response from the server. This can kill the performance of the dependent project. I've experienced the complexity of using the async version of reqwest on earlier versions, but seems it's working much better in the latest version.

Tokio: full

This pulls all of tokio while only a few parts are needed in the compilable code, while the others can be moved to [dev-dependencies]

Dotenv

Love the crate, but this is only required for the tests, so why not have it [dev-dependencies]?

Ring

Can't find where it's used 😢

I'd be more than happy to help on improving and building this library. I can do a PR with some of the proposed cleanups if you like.

Regards,
Marc

[ghost]

Thanks Mark,
The dependencies are for sure improvable for sure as I have been moving things around and from time to time forgot to remove the unused.

Your PR is welcomed!

[TimvanScherpenzeel]

ring was originally used for the Hmac implementation but that has been replaced by the hmac and sha2 so it can be safely removed.

[ghost]

#58