Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Close network connection on crash #188

Open
VidTu opened this issue May 28, 2024 · 2 comments
Open

[Suggestion] Close network connection on crash #188

VidTu opened this issue May 28, 2024 · 2 comments

Comments

@VidTu
Copy link

VidTu commented May 28, 2024

Minecraft (client) never does that, so you are still connected, but not "in world". I don't know if it's easy to shut down netty thread from MC main thread, but should be relatively easy to do so. (with try-catching everything of course, some mixin might inject into closing process and cause double crash)

@natanfudge
Copy link
Owner

It's unlikely I will implement more features myself, but I will accept a PR.

@VidTu
Copy link
Author

VidTu commented Jun 6, 2024

quite possibly i'll be able to make one in a few days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants