Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable restart camera after change mode (photo/video) #805

Closed
Namazed opened this issue Mar 23, 2020 · 15 comments · May be fixed by #806
Closed

Disable restart camera after change mode (photo/video) #805

Namazed opened this issue Mar 23, 2020 · 15 comments · May be fixed by #806
Labels
status:stale

Comments

@Namazed
Copy link
Contributor

Namazed commented Mar 23, 2020

Problem to be addressed

In my app I need fast switch between mode photo and video, because is more comfortable for users, who use camera in my app.

I looked at source code where we switch mode and saw that on Engine.Camera1 we can stop restart camera, because it's not need. On Engine.Camera2 do it it's not simple, because you don't create video and photo recorder for one request, but we can use in one moment photo and video request.

Describe the solution you'd like

I will create PR with solution for Engine.Camera1, because I think I understood how this work.
About Camera2, I tried use both photo and video request in Engine.Camera2 and system threw exception, that telling that request bad configured. Maybe you know how we can do it on Engine.Camera2.

Additional context

This will use flag, like requestPermissions.
@Namazed Namazed mentioned this issue Mar 23, 2020
Open
@stale
Copy link

stale bot commented Apr 12, 2020

This issue has been automatically marked as stale because it has not had activity in the last 20 days. It will be closed if no further activity occurs within the next seven days. Thank you for your contributions.

@stale stale bot added the status:stale label Apr 12, 2020
@Namazed
Copy link
Contributor Author

Namazed commented Apr 13, 2020

Up

@stale stale bot removed the status:stale label Apr 13, 2020
@stale
Copy link

stale bot commented May 3, 2020

This issue has been automatically marked as stale because it has not had activity in the last 20 days. It will be closed if no further activity occurs within the next seven days. Thank you for your contributions.

@stale stale bot added the status:stale label May 3, 2020
@Terenfear
Copy link

Up

@stale stale bot removed the status:stale label May 3, 2020
@stale
Copy link

stale bot commented May 23, 2020

This issue has been automatically marked as stale because it has not had activity in the last 20 days. It will be closed if no further activity occurs within the next seven days. Thank you for your contributions.

@stale stale bot added the status:stale label May 23, 2020
@Terenfear
Copy link

Up

@stale stale bot removed the status:stale label May 24, 2020
@stale
Copy link

stale bot commented Jun 13, 2020

This issue has been automatically marked as stale because it has not had activity in the last 20 days. It will be closed if no further activity occurs within the next seven days. Thank you for your contributions.

@stale stale bot added the status:stale label Jun 13, 2020
@Namazed
Copy link
Contributor Author

Namazed commented Jun 13, 2020

Up

@stale stale bot removed the status:stale label Jun 13, 2020
@stale
Copy link

stale bot commented Jul 3, 2020

This issue has been automatically marked as stale because it has not had activity in the last 20 days. It will be closed if no further activity occurs within the next seven days. Thank you for your contributions.

@stale stale bot added the status:stale label Jul 3, 2020
@Namazed
Copy link
Contributor Author

Namazed commented Jul 5, 2020

up

@stale stale bot removed the status:stale label Jul 5, 2020
@stale
Copy link

stale bot commented Jul 25, 2020

This issue has been automatically marked as stale because it has not had activity in the last 20 days. It will be closed if no further activity occurs within the next seven days. Thank you for your contributions.

@stale stale bot added the status:stale label Jul 25, 2020
@Namazed
Copy link
Contributor Author

Namazed commented Jul 27, 2020

up

@stale stale bot removed the status:stale label Jul 27, 2020
@stale
Copy link

stale bot commented Aug 16, 2020

This issue has been automatically marked as stale because it has not had activity in the last 20 days. It will be closed if no further activity occurs within the next seven days. Thank you for your contributions.

@stale stale bot added the status:stale label Aug 16, 2020
@Namazed
Copy link
Contributor Author

Namazed commented Aug 17, 2020

up

@stale stale bot removed the status:stale label Aug 17, 2020
@stale
Copy link

stale bot commented Sep 6, 2020

This issue has been automatically marked as stale because it has not had activity in the last 20 days. It will be closed if no further activity occurs within the next seven days. Thank you for your contributions.

@stale stale bot added the status:stale label Sep 6, 2020
@stale stale bot closed this as completed Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch mode without restart Namazed/CameraView
2 participants
@Terenfear @Namazed