Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation error in Validation sample program #521

Closed
AGDownie opened this issue Oct 19, 2022 · 2 comments · Fixed by #551
Closed

Documentation error in Validation sample program #521

AGDownie opened this issue Oct 19, 2022 · 2 comments · Fixed by #551
Labels
bug closed-stale This issue is closed because it went stale and there was no action planned. It can be reopened. stale

Comments

@AGDownie
Copy link

Documentation error only.

Affected sample program:
https://github.com/natemcmaster/CommandLineUtils/blob/main/docs/samples/validation/builder-api/Program.cs

These lines in this example program:

29   var importance = app.Option("-i|--importance <IMPORTANCE>", "Low, medium or high", CommandOptionType.SingleValue)
30              .Accepts().Values("low", "medium", "high");

should read:

29   var importance = app.Option("-i|--importance <IMPORTANCE>", "Low, medium or high", CommandOptionType.SingleValue)
30              .Accepts(v => v.Values("low", "medium", "high"));

As it stands the variable importance is of type IValidationBuilder? rather than the expected CommandOption?.

It would also be helpful to show this command option being used in the OnExecute() method.

To Reproduce
N/A

Expected behavior
N/A

Screenshots
N/A

Additional context
Add any other context about the problem here.

@AGDownie AGDownie added the bug label Oct 19, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please comment if you believe this should remain open, otherwise it will be closed in 14 days. Thank you for your contributions to this project.

@github-actions github-actions bot added the stale label Oct 20, 2023
Copy link

github-actions bot commented Nov 3, 2023

Closing due to inactivity.
If you are looking at this issue in the future and think it should be reopened, please make a commented here and mention natemcmaster so he sees the notification.

@github-actions github-actions bot added the closed-stale This issue is closed because it went stale and there was no action planned. It can be reopened. label Nov 3, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 3, 2023
@natemcmaster natemcmaster linked a pull request Nov 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug closed-stale This issue is closed because it went stale and there was no action planned. It can be reopened. stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant