Skip to content

Commit e53584a

Browse files
committed
fix: new option runProgressOnMainThread
1 parent 8eb6c20 commit e53584a

File tree

5 files changed

+8
-4
lines changed

5 files changed

+8
-4
lines changed

packages/https/platforms/android/java/com/nativescript/https/OkHttpResponse.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,12 @@ public class OkHttpResponse {
2525
private final static String TAG = "OkHttpResponse";
2626
static Handler mainHandler = null;
2727
static boolean RUN_ON_MAIN_THREAD = true;
28+
static boolean RUN_PROGRESS_ON_MAIN_THREAD = true;
2829
public static final int DOWNLOAD_CHUNK_SIZE = 2048; // Same as Okio Segment.SIZE
2930

3031
private ResponseBody responseBody;
3132
public boolean runOnMainThread = OkHttpResponse.RUN_ON_MAIN_THREAD;
33+
public boolean runProgressOnMainThread = OkHttpResponse.RUN_PROGRESS_ON_MAIN_THREAD;
3234
public OkHttpResponseProgressCallback progressCallback = null;
3335
public OkHttpResponseCloseCallback closeCallback = null;
3436

@@ -415,10 +417,7 @@ static String responseBodyToString(OkHttpResponse response) throws IOException {
415417
}
416418

417419
public String asString() throws IOException {
418-
// if (RUN_ON_MAIN_THREAD && getMainHandler().getLooper() === Looper.myLooper()) {
419-
// } else {
420420
return responseBodyToString(this);
421-
// }
422421
}
423422

424423
public void asStringAsync(final OkHttpResponseAsyncCallback callback) {

src/https/request.android.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -603,6 +603,9 @@ export function createRequest(opts: HttpsRequestOptions, useLegacy: boolean = tr
603603
if (opts.responseOnMainThread === false) {
604604
nResponse.runOnMainThread = false;
605605
}
606+
if (opts.progressOnMainThread === false) {
607+
nResponse.runProgressOnMainThread = false;
608+
}
606609
if (opts.onProgress) {
607610
nResponse.progressCallback = new OkHttpResponse.OkHttpResponseProgressCallback({
608611
onProgress: opts.onProgress

src/https/request.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@ export interface HttpsRequestOptions extends HttpRequestOptions {
6363
* default to true. Put to false to run response callback on current thread
6464
*/
6565
responseOnMainThread?: boolean;
66+
progressOnMainThread?: boolean;
6667

6768
cachePolicy?: CachePolicy;
6869

src/https/request.ios.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -380,7 +380,7 @@ export function createRequest(opts: HttpsRequestOptions, useLegacy: boolean = tr
380380

381381
const progress = opts.onProgress
382382
? (progress: NSProgress) => {
383-
if (opts.responseOnMainThread === false) {
383+
if (opts.progressOnMainThread === false) {
384384
opts.onProgress(progress.completedUnitCount, progress.totalUnitCount);
385385
} else {
386386
Utils.dispatchToMainThread(() => {

src/https/typings/android.d.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ declare namespace com {
1414
progressCallback: OkHttpResponse.OkHttpResponseProgressCallback;
1515
closeCallback: OkHttpResponse.OkHttpResponseCloseCallback;
1616
runOnMainThread: boolean;
17+
runProgressOnMainThread: boolean;
1718
constructor(body: okhttp3.ResponseBody);
1819
contentLength(): number;
1920
cancel();

0 commit comments

Comments
 (0)