fix: trying to ensure the backdrop always gets hidden and wont interfere with touches

farfromrefug · farfromrefug · commit 412e50381686 · 2024-12-18T09:34:05.000+01:00
diff --git a/src/ui-drawer/index.ts b/src/ui-drawer/index.ts
@@ -880,7 +880,7 @@ export class Drawer extends GridLayout {
             // apply tr data to prevent hickups on iOS
             // and handle animation cancelled errors
             if ((position !== 0 && this.mShowingSide === side) || (position === 0 && !this.mShowingSide)) {
-                this.applyTrData(trData, side);
+                this.applyTrData(trData, this.mShowingSide);
                 if (position !== 0) {
                     // if (trData.backDrop) {
                     //     this.backDrop.opacity = 1;
@@ -890,7 +890,7 @@ export class Drawer extends GridLayout {
                     if (drawer) {
                         drawer.visibility = 'hidden';
                     }
-                    if (this.backDrop && trData.backDrop) {
+                    if (this.backDrop) {
                         this.backDrop.visibility = 'hidden';
                     }
                 }

Original file line number	Diff line number	Diff line change
`@@ -880,7 +880,7 @@ export class Drawer extends GridLayout {`
`880`	`880`	`// apply tr data to prevent hickups on iOS`
`881`	`881`	`// and handle animation cancelled errors`
`882`	`882`	`if ((position !== 0 && this.mShowingSide === side) \|\| (position === 0 && !this.mShowingSide)) {`
`883`		`- this.applyTrData(trData, side);`
	`883`	`+ this.applyTrData(trData, this.mShowingSide);`
`884`	`884`	`if (position !== 0) {`
`885`	`885`	`// if (trData.backDrop) {`
`886`	`886`	`// this.backDrop.opacity = 1;`
`@@ -890,7 +890,7 @@ export class Drawer extends GridLayout {`
`890`	`890`	`if (drawer) {`
`891`	`891`	`drawer.visibility = 'hidden';`
`892`	`892`	`}`
`893`		`- if (this.backDrop && trData.backDrop) {`
	`893`	`+ if (this.backDrop) {`
`894`	`894`	`this.backDrop.visibility = 'hidden';`
`895`	`895`	`}`
`896`	`896`	`}`