Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include_history for object store watch have no effect #638

Open
kfollesdal opened this issue Dec 2, 2024 · 0 comments · May be fixed by #659
Open

include_history for object store watch have no effect #638

kfollesdal opened this issue Dec 2, 2024 · 0 comments · May be fixed by #659
Assignees
@caspervonb
Labels
accepted The defect or proposal as been accepted defect Suspected defect such as a bug or regression

Comments

@kfollesdal
Copy link

kfollesdal commented Dec 2, 2024 •
edited
Loading

Observed behavior

Object store watch function have parameter include_history. If False delivery policy is set to LAST_PER_SUBJECT:

nats.py/nats/js/object_store.py

Line 498 in 7e7883e

if not include_history:

If set to True then deliver_policy = None and then default to ALL:

nats.py/nats/js/client.py

Line 420 in 7e7883e

# NOTE: deliver_policy is defaulting to ALL so check is different for this one.

But messages in underlying meta jetstream for object store is published with Nats-Rollup: sub. So we only have one message for each subject. So with this LAST_PER_SUBJECT and ALL will give same result at consumer start up. If I understand it correct?

Expected behavior

Expect include_history= False to give delivery policy NEW, only receive new changes from start up.

Server and client version

nats.py: 2.9.0

Host environment

No response

Steps to reproduce

No response
@kfollesdal kfollesdal added the defect Suspected defect such as a bug or regression label Dec 2, 2024
@caspervonb caspervonb self-assigned this Feb 3, 2025
@caspervonb caspervonb linked a pull request Feb 3, 2025 that will close this issue
Open
@caspervonb caspervonb added the accepted The defect or proposal as been accepted label Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caspervonb caspervonb

Labels
accepted The defect or proposal as been accepted defect Suspected defect such as a bug or regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix object store watch to use NEW rather than ALL nats-io/nats.py
2 participants
@caspervonb @kfollesdal