Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

This line is broken #637

Open
sevenrats opened this issue Nov 27, 2024 · 2 comments · May be fixed by #660
Open

This line is broken #637

sevenrats opened this issue Nov 27, 2024 · 2 comments · May be fixed by #660
Assignees
@caspervonb
Labels
defect Suspected defect such as a bug or regression

Comments

@sevenrats
Copy link

Observed behavior

you fail to await the server discovery callback even though you enforce it being a coroutine

Expected behavior

this needs to be awaited

nats.py/nats/aio/client.py

Line 1902 in 7e7883e

self._discovered_server_cb()

Server and client version

2.10.22, main

Host environment

No response

Steps to reproduce

No response
@sevenrats sevenrats added the defect Suspected defect such as a bug or regression label Nov 27, 2024
@sevenrats
Copy link
Author

so you are probably missing test coverage for this as well

@wallyqs
Copy link
Member

wallyqs commented Nov 27, 2024

thanks for the report, it looks like we did have coverage but it was using mocks so it was just wrong 🙃
f935963#diff-fb70e4c2ac585473a9714d1f1c39a0d94bb1ef4802b9d51429b73df49316f23eR1466

@caspervonb caspervonb self-assigned this Feb 12, 2025
@caspervonb caspervonb linked a pull request Feb 12, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caspervonb caspervonb

Labels
defect Suspected defect such as a bug or regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix discovered server callback not being awaited nats-io/nats.py
3 participants
@wallyqs @caspervonb @sevenrats