Fix instrument.id null dereferences in error logs

Author: cjdsellers

RELEASES.md

@@ -43,6 +43,8 @@ This release will be the final version that uses Poetry for package and dependen
 - Fixed typo in `delta.rs` doc comment (#2230), thanks @eltociear
 - Fixed memory leak in network PyO3 layer caused by the `gil-refs` feature (#2229), thanks for reporting @davidsblom
 - Fixed reconnect handling for Betfair (#2232), thanks @limx0
+- Fixed `instrument.id` null dereferences in error logs (#2237), thanks for reporting @ryantam626
+- Fixed schema for listing markets of dYdX (#2240), thanks @davidsblom
 
 ### Documentation Updates
 - Added Databento overview (#2233), thanks @stefansimik

nautilus_trader/portfolio/portfolio.pyx

@@ -183,7 +183,7 @@ cdef class Portfolio(PortfolioFacade):
             if instrument is None:
                 self._log.error(
                     f"Cannot update initial (order) margin: "
-                    f"no instrument found for {instrument.id}"
+                    f"no instrument found for {instrument_id}"
                 )
                 initialized = False
                 break
@@ -274,7 +274,7 @@ cdef class Portfolio(PortfolioFacade):
             if instrument is None:
                 self._log.error(
                     f"Cannot update maintenance (position) margin: "
-                    f"no instrument found for {instrument.id}"
+                    f"no instrument found for {instrument_id}"
                 )
                 initialized = False
                 break

nautilus_trader/risk/engine.pyx

@@ -427,7 +427,7 @@ cdef class RiskEngine(Component):
         if instrument is None:
             self._deny_command(
                 command=command,
-                reason=f"Instrument for {command.instrument_id} not found",
+                reason=f"Instrument for {order.instrument_id} not found",
             )
             return  # Denied