feat: support CSI for nautobot-static volume #518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @david-kn, thank you for creating a PR. The CSI approach seems very use-case specific. What if we change the approach and make it more generic? What I am thinking is that we can introduce a new value, something like |
|
Hi, thanks for your reply and I agree - let's make it more generic. I understand that CSI approach of ours is kinda specific :-) |
|
@david-kn do you want to prepare a PR? |
|
Hi Uros, I'd prefer you prepare it so it fits your idea and covers better your generic approach (feel free to close this PR or whatever you need). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #517
My idea to support CSI volume for
nautobot-staticvolume.WDYT?
Side notes with my first contribution to your helm repo:
Chart.yamlnorCHANGELOG.mdfiles which states that it was moved?]--no-verifyI hope I won't cause much of extra work on your end :-)