feat: use uwsgi with http only #520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gertzakis
requested changes
Mar 6, 2025
Co-authored-by: Gerasimos Tzakis <[email protected]>
Happy to contribute :-) Thanks for your proposals. I think so ;-) I'll try to take a look at it how it is connected there... |
|
Put condition around exposing 8443 port. Please, take a look if it meet your standards and approach. |
gertzakis
approved these changes
Mar 20, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #519
To have an option to disable HTTPS communication within uWSGi.
Security of HTTPS can be handled by ingress which terminates TLS traffic and I find this useful / actually necessary when running in Kubernetes with only read-only filesystem that disallow processes to touch nautobot.crt and nautobot.key files defined within uwsgi.ini and cause an error during deployment (current state).
Of course other option is to enable nginx sidecar with nautobot but I think this could be useful for some scenarios.
Tried to update also docs and validation scheme which impacted quite many other lines...