Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Clickable Artists work but it fails for Artists without Albums #2658

Closed
3 tasks done
kobayashi90 opened this issue Nov 27, 2023 · 11 comments
Closed
3 tasks done
Labels
bug stale triage New bug reports that need to be evaluated

Comments

@kobayashi90
Copy link

kobayashi90 commented Nov 27, 2023

I confirm that:

  • I have searched the existing open AND closed issues to see if an issue already exists for the bug I've encountered
  • I'm using the latest version (your issue may have been fixed already)

Version

0.50.1

Current Behavior

Exspecting that it doesnt show an error like this one if you click on an Artist without an Album.
firefox_TrEYjTwaYB

Expected Behavior

Well that its working?

Steps To Reproduce

Create an Album with Various Artists and have for example Mozart on track 1-10 and Bach on track 11.

Environment

- OS: Windows 11
- Browser: Firefox
- Client: Navidrome Web

How Navidrome is installed?

Docker

Configuration

-

Relevant log output

-

Anything else?

Code of Conduct

  • I agree to follow Navidrome's Code of Conduct
@kobayashi90 kobayashi90 added bug triage New bug reports that need to be evaluated labels Nov 27, 2023
@deluan
Copy link
Member

deluan commented Nov 28, 2023

This can happen if the album was just imported but the scan process is still running. Can you confirm the scan process finished successfully?

@certuna
Copy link
Contributor

certuna commented Nov 28, 2023

Yeah this should only happen during the scan, afterwards the non-album artists are cleaned up and the links disappear.

#2583 fixes this by making all artists clickable, but isn't merged yet

@kobayashi90
Copy link
Author

well then please merge it @deluan and make an 0.50.2 or something because i had to downgrade before ive got many errors while moving from 0.49.3 to 0.50.1 like the date formatting not being accepted (example: 10/09/2011) and others like musicbrainz id missing even tho the file doesnt had that tag to beginn with..
firefox_EQo8NJ7hMK

@kobayashi90
Copy link
Author

#2583 fixes this by making all artists clickable, but isn't merged yet

Ah i didnt seen this change for some reason but great that somebody already solved that problem.

@deluan
Copy link
Member

deluan commented Nov 29, 2023

well then please merge it @deluan and make an 0.50.2 or something because i had to downgrade before ive got many errors while moving from 0.49.3 to 0.50.1 like the date formatting not being accepted (example: 10/09/2011) and others like musicbrainz id missing even tho the file doesnt had that tag to beginn with.. firefox_EQo8NJ7hMK

These are just warnings to let you know there's something wrong with your tags. They are not something new in 0.50.1, it has always been like this, is just that you didn't noticed before :)

And as @certuna and I said, clicking on an artist without albums is only an issue while the full scan is happening. Once it finishes, all artists without albums should have their links removed.

Please confirm this is your case (scan still running)

@certuna
Copy link
Contributor

certuna commented Nov 30, 2023

ive got many errors while moving from 0.49.3 to 0.50.1 like the date formatting not being accepted (example: 10/09/2011)

This is not a bug, your tags have incorrectly formatted dates. Date tags should be in the ISO 8601 format 2011-09-10, see the tag specs.

10/09/2011 is impossible to parse since it could mean either 10 September or 9 October.

@kobayashi90
Copy link
Author

kobayashi90 commented Dec 1, 2023

10/09/2011 is impossible to parse since it could mean either 10 September or 9 October.

Alright will ignore this error then.

Please confirm this is your case (scan still running)

After Scan it fixed itself but newly added albums show all artists being clickable as shown here.
Also here is what the logs say
t5282cmeZi

Edit: Somehow after editing the Album again the clickable artist fixed itself, you should still fix this problem tho.

@deluan
Copy link
Member

deluan commented Dec 2, 2023

Edit: Somehow after editing the Album again the clickable artist fixed itself, you should still fix this problem tho.

The "fix" will be importing all artists, as per @certuna's PR. Let's keep this issue open so other people can find it while the PR is not merged.

@kobayashi90
Copy link
Author

The "fix" will be importing all artists, as per @certuna's PR. Let's keep this issue open so other people can find it while the PR is not merged.

Any idea when this will be pushed to master?

@deluan
Copy link
Member

deluan commented Dec 6, 2023

Any idea when this will be pushed to master?

The PR requires more testing and needs to be checked for conflicts with other ongoing implementations. This may take a couple of months or so.

Copy link

github-actions bot commented Jun 3, 2024

This issue has been automatically marked as stale because it has not had recent activity. The resources of the Navidrome team are limited, and so we are asking for your help.
If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open.
If this is a feature request, and you feel that it is still relevant and valuable, please tell us why.
This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

@github-actions github-actions bot added the stale label Jun 3, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug stale triage New bug reports that need to be evaluated
Projects
None yet
Development

No branches or pull requests

3 participants