Switch to JSpecify

[koppor]

I really like that the code has non-null annotations.

There is a long discussion about the "right" null annotation: https://stackoverflow.com/q/4963300/873282

Fortunately, Google, JetBrains, Facebook, Uber and others managed to agree on one annotation: JSpecify. I especially like @NullMarked which indicates that the all nullalbes places have explicitly marked - and all other places are non-null.

I suggest to switch from the JetBrains-focused Nullable annotations to the ones of JSpecify.

[charphi]

I agree; NPE is a recurring problem.

However, I have some concerns about the stability of this new API/specification. It was announced a couple of years ago but is still not released.

[koppor]

I also kind of hesitated to use/switch. However, the adoption page reads very interesting: https://github.com/jspecify/jspecify/wiki/adoption

As of JSpecify 0.3, it's now extremely unlikely there will be any compilation-breaking change to the four annotation interfaces (exception [NullMarked on methods]). We're not moving, renaming, or removing anything anymore. So once your tools recognize them at all, then switching probably couldn't hurt much.

[koppor]

Side note: When switching, internal.nbbrd.service.com.github.javaparser.quality.NotNull needs to re replaced, too. 😋