Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to handle geoserver's envrionment variable in better way. #17

Open
ywkim312 opened this issue Dec 5, 2023 · 0 comments
Open

Need to handle geoserver's envrionment variable in better way. #17

ywkim312 opened this issue Dec 5, 2023 · 0 comments
Assignees

Comments

@ywkim312
Copy link
Collaborator

ywkim312 commented Dec 5, 2023

Currently, geoserver's env variables are being used separately in the chart. Make those in the one place so make it to easier to modify or check.
For example, it is currently like

cors:
  enabled: true

extension:
  install: false
  stableExtension: ""

demoData:
  skip: true

envs:
  extraJavaOpts: "-Xms512m -Xmx2g"

but it could be better if it goes like

env
  cors:
    enabled: true
  extension:
    install: false
    stableExtension: ""
  demoData:
    skip: true
  extraJavaOpts: "-Xms512m -Xmx2g"

and also in the deployment yaml file, it might be better to use something like

- name: EXTRA_JAVA_OPTS
   value: {{ .Values.envs.extraJavaOpts | quote }}
{{ with .Values.envs }}
            - name: .key
               value: .value
{{ end }}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant