Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for parsing json in ObjectNames() #182

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support for parsing json in ObjectNames() #182

wants to merge 1 commit into from

Conversation

yheonhochoi
Copy link

fix #181

It does not contain implementations for other types.

However, if a request is made with json format, the body of the received resp is parsed and the name list is returned.

@yheonhochoi
Copy link
Author

@ncw

Can I get an update on this?

It's not a big change, but it's a necessary setting in my environment.

Any additional feedback is welcome and will be checked.

ncw
ncw reviewed Jun 10, 2023
View reviewed changes
Copy link
Owner

@ncw ncw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay.

This code looks OK.

I'd like to know why swift is returning JSON when we haven't asked for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncw ncw ncw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for parsing json in ObjectNames()
2 participants
@yheonhochoi @ncw