Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Spec fails when some parts of spec are invalid #27

Open
bodom0015 opened this issue Nov 9, 2023 · 0 comments
Open

Import Spec fails when some parts of spec are invalid #27

bodom0015 opened this issue Nov 9, 2023 · 0 comments

Comments

@bodom0015
Copy link
Member

bodom0015 commented Nov 9, 2023

Found while testing https://github.com/cheese-hub/catalog/pull/20/files

Step to Reproduce

  1. Navigate to /my-catalog and click Import Spec
    • You should see a dialog appear that allows you to import this new spec
  2. Paste the spec JSON from the above PR
  3. Click "Import" at the bottom right of the dialog

Expected Results

Spec validation error should be displayed on screen (or we workaround the format errors and fix them for the user)

Actual Results

Screen turns white and page does not finish loading

API Response:

{
  "detail": "1000 is not of type 'string' - 'resourceLimits.cpuMax'",
  "status": 400,
  "title": "Bad Request",
  "type": "about:blank"
}

Frontend error caused by API Response:

Failed to import new spec with key=svmpoisoningexample:  Error: Validation failed - spec is invalid
    at se (main.954c9ebe.chunk.js:1:10855)
    at main.954c9ebe.chunk.js:1:11297
    at p (2.03cca15f.chunk.js:2:1550)
    at Generator.<anonymous> (2.03cca15f.chunk.js:2:2897)
    at Generator.next (2.03cca15f.chunk.js:2:1913)
    at r (2.03cca15f.chunk.js:2:8517)
    at s (2.03cca15f.chunk.js:2:8720)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant