[Bounty] Lockup

[willemneal]

NEAR Bounty Terms

Before beginning work on the bounty, you must submit a proposal. Only if your proposal is accepted will you be able to claim the reward of the bounty. In particular for this bounty you need to detail the testing you will use other than unit testing.

There should be at most 1 week between proposal is accepted and you start working on the bounty. It should take you at most 1 month to complete the bounty.

Description

For this bounty you will need to rewrite the lockup contract into AssemblyScript making sure that they have the same API.

Context

With the new addition of includeBytes function in AssemblyScript, near-sdk-as should have enough parity with near-sdk-rs that the core smart contracts should be able to be written in AS. The trickiest part of the contracts are the cross contract calls. Rust provides a high level abstraction for working with promises. For an example for batch promise calls in AS see the sdk's repo here.

Relevant repos or issues

Core Contracts

API

Same as rust contracts.

Acceptance Criteria

• [ ] Including the unit tests
• [ ] Test contracts another way

Bounty

200 DAI

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

Work has been started.

These users each claimed they can complete the work by 266 years, 2 months from now.
Please review their action plans below:

1) developerfred has applied to start work (Funders only: approve worker | reject worker).

Proposal:

I would like to work on this issue, I will follow all the contract construction guidelines proposed by Near used the lib near-ask-as.

I will write the tests in jest, and test the compiled contract. Having success in this issue I intend to apply to rewrite other contracts.
2) musiklasik has applied to start work (Funders only: approve worker | reject worker).

Email paypal planetlagu@yahoo.com
3) evgeniuz has been approved to start work.

Will reimplement the contract in AssemblyScript. In addition to unit tests I will use simulation tests on compiled contract (especially to check cross-contract calls) and some testing on testnet. I've applied to all three reimplementations as I think they're quite similar and reimplementation after the first one will be much faster, so it would be possible to work on all three at once.

Learn more on the Gitcoin Issue Details page.

[gitcoinbot]

@evgeniuz Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• reminder (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@evgeniuz Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• reminder (3 days)
• escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[willemneal]

@evgeniuz, as stated in the bounty you must start work on the bounty within a week. Have you started? If so, could you please open a PR to this repo that will fix this issue?

[evgeniuz]

@willemneal, I've already started working on this, will open PR in a day or so.

[willemneal]

In the future, the first step should be to open a WIP PR so that gitcoin is happy.