-
Notifications
You must be signed in to change notification settings - Fork 12
feat: re-submit attestation if node detects it has no attestation on chain #1223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a mechanism to automatically re-submit attestations when a node detects it has been removed from the participant list on the blockchain. This helps ensure nodes maintain valid attestations after resharing events or other participant changes.
- Adds monitoring for contract state changes to detect participant removal
- Implements automatic attestation resubmission when a node transitions from participant to non-participant
- Spawns a dedicated task to continuously monitor contract state and trigger resubmissions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
crates/node/src/tee/remote_attestation.rs |
Implements core attestation monitoring logic and resubmission functionality |
crates/node/src/cli.rs |
Integrates the new monitoring task into the node startup process |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
f6d455c to
adb633e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
netrome
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test looks great now. I have some code nits but nothing blocking. I feel like we're duplicating some logic that can be unified. Primarily the retry loops and attestation submission logic.
…-attestations-detection
netrome
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Thanks for the updates
Fixes #1198