Skip to content

Conversation

@pbeza
Copy link
Contributor

@pbeza pbeza commented Oct 3, 2025

Fixes #1198

@pbeza pbeza requested a review from Copilot October 3, 2025 13:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a mechanism to automatically re-submit attestations when a node detects it has been removed from the participant list on the blockchain. This helps ensure nodes maintain valid attestations after resharing events or other participant changes.

  • Adds monitoring for contract state changes to detect participant removal
  • Implements automatic attestation resubmission when a node transitions from participant to non-participant
  • Spawns a dedicated task to continuously monitor contract state and trigger resubmissions

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
crates/node/src/tee/remote_attestation.rs Implements core attestation monitoring logic and resubmission functionality
crates/node/src/cli.rs Integrates the new monitoring task into the node startup process

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@pbeza pbeza force-pushed the pab/1198-resubmission-attestations-detection branch from f6d455c to adb633e Compare October 3, 2025 15:55
@pbeza pbeza marked this pull request as ready for review October 6, 2025 12:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@pbeza pbeza requested a review from gilcu3 October 6, 2025 13:54
@pbeza pbeza self-assigned this Oct 6, 2025
Copy link
Collaborator

@netrome netrome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test looks great now. I have some code nits but nothing blocking. I feel like we're duplicating some logic that can be unified. Primarily the retry loops and attestation submission logic.

@pbeza pbeza enabled auto-merge October 7, 2025 10:32
@pbeza pbeza added this pull request to the merge queue Oct 7, 2025
Copy link
Collaborator

@netrome netrome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks for the updates

Merged via the queue into main with commit 4304f1f Oct 7, 2025
10 checks passed
@pbeza pbeza deleted the pab/1198-resubmission-attestations-detection branch October 7, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Node should re-submit attestation if it detects it has no attestation on chain

3 participants