Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActionError::FunctionCallError is a free form string #1731

Closed
evgenykuzyakov opened this issue Nov 19, 2019 · 1 comment
Closed

ActionError::FunctionCallError is a free form string #1731

evgenykuzyakov opened this issue Nov 19, 2019 · 1 comment
Labels
A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) C-housekeeping Category: Refactoring, cleanups, code quality
Milestone
Outdated

Comments

@evgenykuzyakov
Copy link
Collaborator

We should use subtypes of VMError::FunctionCallError to better handle ActionError::FunctionCallError
@evgenykuzyakov evgenykuzyakov added A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) C-housekeeping Category: Refactoring, cleanups, code quality labels Nov 19, 2019
@ilblackdragon ilblackdragon added this to the MainNet milestone Dec 8, 2019
@MaksymZavershynskyi
Copy link
Contributor

Addressed by #1854

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) C-housekeeping Category: Refactoring, cleanups, code quality
Projects
None yet
Milestone
Outdated
Development

No branches or pull requests
3 participants
@ilblackdragon @evgenykuzyakov @MaksymZavershynskyi