Remove encoding package from dependencies

[MelkorNemesis]

before working on this, please check if the published version of the package @actions/github is more recent than the one shown below. If it isn't there's no chance this issue can be fixed

node-fetch version 2.6.7 has been causing us some esm/cjs compatibility issues. To avoid these issues we had to manually install encoding package as a dependency. Newer versions of node-fetch package no longer have encoding package as just a peerDependency (or dependency or devDependency) and when we learn that the application is using newer version of node-fetch we can remove the dependency from package.json.

$ npm ls node-fetch
[email protected]
└─┬ @actions/[email protected]
  └─┬ @octokit/[email protected]
    └─┬ @octokit/[email protected]
      └── [email protected]

More information about the issue:

• chore: install encoding package to prevent ncc from outputting eval("require") #87
• chore: add check that dist/index.js does not include eval('require') or eval("require") strings #97

[denes-fekeshazy]

Currently the application is still using @actions/[email protected], so we can not remove encoding as a dependency yet.
Also the problem is that while [email protected] does not list encoding as a dependency, it does trying to load the library in one of its functions. At build time it would produce the following code: module.exports = eval("require")("encoding");. Which is then failing the eval("require") check on this repo.

[simoneb]

Correct. We have also put in place a test in CI which checks what ncc generates so that we know if the issue is still there. When we remove the dummy encoding dependency, if that test fails we know that the issue is still there.