Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Address name works in Account API #592

Open
wayneyaoo opened this issue Feb 7, 2023 · 2 comments
Open

[Bug] Address name works in Account API #592

wayneyaoo opened this issue Feb 7, 2023 · 2 comments
Labels
bug Something doesn’t work properly

Comments

@wayneyaoo
Copy link

Bug Description

I'm not completely sure if these two API should work (but they actually work).

https://api.omg.lol/account/wy-test/addresses
https://api.omg.lol/account/wy-test/sessions

because the accont/{stuff} is supposed to be an email address, not an address inside the account.

Given this

https://api.omg.lol/account/wy-test/info

and this

https://api.omg.lol/account/wy-test/name

don't work, the above two should not work right?

I understand there's nuance between the modeling of "account" and "address" and they're ever changing. Totally fine if we have a clear definition of both and correct reflection in API in the later overhaul.

Steps to Reproduce

No response

@wayneyaoo wayneyaoo added the bug Something doesn’t work properly label Feb 7, 2023
@ejstreet
Copy link

ejstreet commented Feb 8, 2023

Is this a bug, or a feature? :) Should be documented though if the latter

@wayneyaoo
Copy link
Author

wayneyaoo commented Feb 8, 2023

Is this a bug, or a feature? :) Should be documented though if the latter

seems to a bug but let's wait for adam's confirmation.. since wy-test is not an email address, and not following the pattern

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something doesn’t work properly
Projects
None yet
Development

No branches or pull requests

2 participants