Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement exhibits_url to fetch exhibits from an external URL #15

Open
krassowski opened this issue Jun 11, 2024 · 4 comments · May be fixed by #50
Open

Implement exhibits_url to fetch exhibits from an external URL #15

krassowski opened this issue Jun 11, 2024 · 4 comments · May be fixed by #50

Comments

@krassowski
Copy link
Member

To make the configuration easier, GalleryManager.exhibits_url should be available allowing to fetch the exhibits from a JSON or yaml file

@krassowski
Copy link
Member Author

Ability to change examples without redeploying would be really useful for conferences where multiple instructors contribute example repositories asynchronously and the person compiling the list may not necessarily have rights to redeploy.

@andrewfulton9
Copy link
Collaborator

I have a couple of questions about this:

Is the expectation here that the a get request to the URL would directly return a json object?

Should exhibits_url override exhibits defined in GalleryManager.exhibits, or maybe append to them?

@krassowski
Copy link
Member Author

Is the expectation here that the a get request to the URL would directly return a json object?

Yes. In practice this could be a file in a GitHub repo but linked using raw URL pointing to a branch.

Should exhibits_url override exhibits defined in GalleryManager.exhibits, or maybe append to them?

No strong opinion. What do you think would be better?

@andrewfulton9
Copy link
Collaborator

No strong opinion. What do you think would be better?

I don't think I have a string opinion on which would be better. I am leaning towards appending the exhibits from exhibits_url though. Is it possible to make traitlet behavior dependent on other traitlets? If we were going to have exhibits_url override exhibits, then I would probably want to make it so both can not be set in the configuration in the first place. On the other hand, I could probably add a setting that determines which is displayed. I think the simplest and the best UX would just to combine the exhibits though.

@andrewfulton9 andrewfulton9 linked a pull request Jan 29, 2025 that will close this issue
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants