Skip to content
This repository has been archived by the owner on Dec 31, 2024. It is now read-only.

Bug Report: Alt note doesn't work #105

Open
HumanKR opened this issue Jun 24, 2022 · 2 comments
Open

Bug Report: Alt note doesn't work #105

HumanKR opened this issue Jun 24, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@HumanKR
Copy link
Contributor

HumanKR commented Jun 24, 2022

Please check for duplicates or similar issues, as well performing simple troubleshooting steps (such as clearing cookies, clearing AppData, trying another browser) before submitting an issue.

If you are playing a downloaded version of the game, what operating system are you using?

Windows (x86), Windows (x86_64), Linux, or macOS? Specify below.

Windows 10 (x86_64)

What version of the game are you using? Look in the bottom left corner of the main menu.

latest version

Have you identified any steps to reproduce the bug? If so, please describe them below. Use images if possible.

Actually I'm not good at english sooo i'll try to explain this bug in a nutshell.
image

in the playstate, there is some code about altanim inside playAnimationNote function.
ok if noteType is alt, then altAnim is '-alt' right?
then lets go to that function.

image

and this is important part of this function about alt animation.
i add some trace for figure out what is problem.

image

yea... the final suffix is "-alt-alt"
we must be delete the code if(daNote.noteType=='alt')suffix+='-alt';
becuase that's already got suffix before
(altAnim = '-alt'; in !daNote.mustPress && daNote.canBeHit && !daNote.wasGoodHit)

image

aaaand yea it works nicely

If you have any other good ideas, please fix them <3

@HumanKR HumanKR added the bug Something isn't working label Jun 24, 2022
@nebulazorua
Copy link
Owner

yeah i noticed this a while ago and I've been meaning to get around to fixing this, but I've been busy w/ alot of projects
If you'd like to do a pull request w/ your fix I'll merge it

@HumanKR
Copy link
Contributor Author

HumanKR commented Jun 25, 2022

yeah i noticed this a while ago and I've been meaning to get around to fixing this, but I've been busy w/ alot of projects If you'd like to do a pull request w/ your fix I'll merge it

I pulled now!
I don't know because it's my first time, but I think it went well!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants