Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Team doesn't work as a group #109

Open
josh-bartz opened this issue Sep 18, 2023 · 1 comment
Open

Github Team doesn't work as a group #109

josh-bartz opened this issue Sep 18, 2023 · 1 comment

Comments

@josh-bartz
Copy link

I have a github team that I'm trying to automatically request reviews by all team members, for all team members.

Ex: team-1 consists of [dev1, dev2, dev3]. If dev2 submits a PR, I want dev1 and dev3 to be requested automatically. However, only the following seems to work:

reviewers:
  groups:
    group-1
      - dev1
      - dev2
      - dev3

  per_author:
    group-1
      - team:team-1

I would have expected this to work, too:

reviewers:
  groups:
    group-1
      - team:team-1

  per_author:
    group-1
      - team:team-1

Setting enable_group_assignment: true doesn't work, either. Is there a way to do this that I'm missing?

@swrobel
Copy link
Contributor

swrobel commented Aug 13, 2024

I'm using almost exactly the style of config in your second example, with these config options, and it works great!

I misunderstood, and it's not actually working properly because it's recognizing that the author is a member of the specified team, but instead it's just falling back to assigning the default team as the reviewer, which happened to be correct in my case.

I have opened a PR to address this erroneous README suggestion in #124

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants