Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TODO][good first issue] Uncap pylint-pytest in the dependency lists and lock files #125

Closed
3 tasks
webknjaz opened this issue Apr 24, 2024 · 3 comments
Closed
3 tasks

Comments

@webknjaz
Copy link
Contributor

It's pinned in a few files @ requirements/: https://github.com/search?q=repo%3Anedbat%2Fscriv%20pylint-pytest&type=code. This is due to reverbc/pylint-pytest#20. The original project repository has been archived but the successor is being published to PyPI under the same project name and is hosted under @pytest-dev. They've ported my PR reverbc/pylint-pytest#22 and merged it as pylint-dev/pylint-pytest#15, releasing that under v1.1.6.

I just tried it out in another project and it ended up displaying a more informative error

. (C  0), ::F6401
************* Module cheroot.test.test_conn
cheroot/test/test_conn.py:L   1:(cannot-enumerate-pytest-fixtures) pylint-pytest plugin cannot enumerate and collect pytest fixtures. Please run `pytest --fixtures --collect-only cheroot/test/test_conn.py` and resolve any potential syntax error or package dependency issues. stdout: . stderr: ERROR: usage: pylint [options] [file_or_dir] [file_or_dir] [...]
pylint: error: unrecognized arguments: --numprocesses=auto --cov=cheroot --cov-report --cov-report xml:.test-results/pytest/cov.xml ~/src/github/cherrypy/cheroot--maintenance--macos-13/cheroot/test/test_conn.py
  inifile: ~/src/github/cherrypy/cheroot--maintenance--macos-13/pytest.ini
  rootdir: ~/src/github/cherrypy/cheroot--maintenance--macos-13

which made it more obvious that I'm lacking a few pytest plugins in the env where pylint is installed.

Action items

  • Delete the plugin entry from requirements/constraints.txt along with a comment explainer
  • Regenerate requirements/dev.txt and requirements/quality.txt with pip-tools using -P pylint-pytest arg
  • Check what pylint outputs after that, fix any linting violations and perhaps add more missing deps to requirements/quality.in, repeating the previous steps
@webknjaz
Copy link
Contributor Author

@OlenaYefymenko would you like to give it a go?

@OlenaYefymenko
Copy link

@OlenaYefymenko would you like to give it a go?

Yes, I'll solve this.

OlenaYefymenko added a commit to OlenaYefymenko/scriv that referenced this issue Apr 26, 2024
This patch removes the pinned version of `pylint-pytest` from
the constraints.txt file. It also updates the dependency to the
version v1.1.7 in requirements/dev.txt and requirements/quality.txt.

Fixes nedbat#125
OlenaYefymenko added a commit to OlenaYefymenko/scriv that referenced this issue Apr 26, 2024
This patch removes the pylint-pytest from the constraints.txt
file. This change also updates the dependency to the version v1.1.7
in requirements/dev.txt and requirements/quality.txt

Fixes nedbat#125
@nedbat
Copy link
Owner

nedbat commented May 5, 2024

Fixed in commit 53473f0

@nedbat nedbat closed this as completed May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants