Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TODO][good first issue] Update packaging metadata to clarify support for Python 3.7+ #126

Closed
2 tasks
webknjaz opened this issue Apr 24, 2024 · 1 comment
Closed
2 tasks

Comments

@webknjaz
Copy link
Contributor

So apparently, the wheel published on PyPI is tagged as py2.py3 for which the label Python 2 shows up on the web page @ https://pypi.org/project/scriv/1.5.1/#files.

The Trove classifiers only list Python versions starting with 3.7, though. And that's the lowest version found in CI and various linters like MyPy.

This of course, can lead to some confusion both for the users and the installer software. Here's what I propose.

Action items

  • remove the [wheel] ([bdist_wheel]) section from setup.cfg — this will result in the .whl files having just the py3 tag in their names
  • add python_requires = >= 3.7 to setup.cfg under [options] — this will make sure a Require-Python is included in the packaging metadata, allowing the installers to know what runtimes are supported; if done after Transition into pyproject.toml #117, an equivalent setting should be added to pyproject.toml
@nedbat
Copy link
Owner

nedbat commented May 7, 2024

Fixed in commit b87175c. Thanks for the instructions!

@nedbat nedbat closed this as completed May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants