Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pendingRequests accessed from different queues #24

Open
pc-zhang opened this issue Jul 4, 2019 · 6 comments
Open

pendingRequests accessed from different queues #24

pc-zhang opened this issue Jul 4, 2019 · 6 comments
Labels

Comments

@pc-zhang
Copy link

pc-zhang commented Jul 4, 2019

I observed URLSessionDelegate and AVAssetResourceLoaderDelegate methods are called from different queues, and they both access pendingRequests.

@neekeetab
Copy link
Owner

Thanks for pointing out!

@neekeetab neekeetab added the bug label Jul 9, 2019
@neekeetab
Copy link
Owner

This can be a cause for #13

@pc-zhang
Copy link
Author

You are welcome :-)

@Kaspik
Copy link

Kaspik commented Sep 17, 2019

@neekeetab Any update on this? It's definitely cause of crashes and currently, after we added CachingPlayerItem to our project, it's the biggest crash on Fabric. 😞

@neekeetab
Copy link
Owner

I’m sorry for the crashes. Most likely it’s due to the race conditions. Adding a private queue may do it

@zackperdue
Copy link

Is there a solution to this? My users are reporting crashes and this is cause. I'd help out but I'm not that good at multithreaded swift code. Really need a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants