Fix platform parsing to support multiple equals signs #5961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use strings.LastIndex instead of strings.Split to correctly parse platform strings containing multiple equals signs (e.g., runner=fast-disk-network=catthehacker/ubuntu:act-22.04). This allows the platform key to contain equals signs, splitting only on the last occurrence to separate the key from the value.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5961 +/- ##
==========================================
+ Coverage 74.65% 76.74% +2.08%
==========================================
Files 73 73
Lines 11139 9201 -1938
==========================================
- Hits 8316 7061 -1255
+ Misses 2186 1505 -681
+ Partials 637 635 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Would be nice to get this added, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use strings.LastIndex instead of strings.Split to correctly parse platform strings containing multiple equals signs (e.g., runner=fast-disk-network=catthehacker/ubuntu:act-22.04).
This allows the platform key to contain equals signs, splitting only on the last occurrence to separate the key from the value.