Move configurations from :core to :config-api

Author: vnickolov

applications/graph-store-catalog/src/main/java/org/neo4j/gds/applications/graphstorecatalog/FictitiousGraphStoreLoader.java

@@ -25,6 +25,7 @@
 import org.neo4j.gds.api.ResultStore;
 import org.neo4j.gds.config.GraphProjectConfig;
 import org.neo4j.gds.core.GraphDimensions;
+import org.neo4j.gds.core.GraphStoreFactorySupplier;
 import org.neo4j.gds.core.ImmutableGraphDimensions;
 import org.neo4j.gds.mem.MemoryEstimation;
 import org.neo4j.gds.projection.GraphProjectFromStoreConfig;
@@ -69,16 +70,16 @@ public GraphDimensions graphDimensions() {
 
     @Override
     public MemoryEstimation estimateMemoryUsageDuringLoading() {
-        return graphProjectConfig
-            .graphStoreFactory()
+        return GraphStoreFactorySupplier
+            .supplier(graphProjectConfig)
             .getWithDimension(GraphLoaderContext.NULL_CONTEXT, graphDimensions())
             .estimateMemoryUsageDuringLoading();
     }
 
     @Override
     public MemoryEstimation estimateMemoryUsageAfterLoading() {
-        return graphProjectConfig
-            .graphStoreFactory()
+        return GraphStoreFactorySupplier
+            .supplier(graphProjectConfig)
             .getWithDimension(GraphLoaderContext.NULL_CONTEXT, graphDimensions())
             .estimateMemoryUsageAfterLoading();
     }

applications/graph-store-catalog/src/test/java/org/neo4j/gds/applications/graphstorecatalog/StubGraphProjectConfig.java

@@ -21,7 +21,6 @@
 
 import org.apache.commons.lang3.builder.ToStringBuilder;
 import org.apache.commons.lang3.builder.ToStringStyle;
-import org.neo4j.gds.api.GraphStoreFactory;
 import org.neo4j.gds.config.GraphProjectConfig;
 
 import java.util.Map;
@@ -59,10 +58,10 @@ public Map<String, Object> asProcedureResultConfigurationField() {
         throw new UnsupportedOperationException("TODO");
     }
 
-    @Override
-    public GraphStoreFactory.Supplier graphStoreFactory() {
-        throw new UnsupportedOperationException("TODO");
-    }
+//    @Override
+//    public GraphStoreFactory.Supplier graphStoreFactory() {
+//        throw new UnsupportedOperationException("TODO");
+//    }
 
     @Override
     public Optional<String> usernameOverride() {

config-api/build.gradle

@@ -5,9 +5,36 @@ description = 'Neo4j Graph Data Science :: Config API'
 group = 'org.neo4j.gds'
 
 dependencies {
+    annotationProcessor project(':annotations')
+    annotationProcessor project(':config-generator')
+    annotationProcessor openGds.immutables.builder
+    annotationProcessor openGds.immutables.value
+    annotationProcessor group: 'org.neo4j', name: 'annotations', version: ver.'neo4j'
+
     compileOnly project(':annotations')
     compileOnly openGds.immutables.value.annotations
     compileOnly openGds.jetbrains.annotations
 
+    // Neo4j Dependencies
+    // `org.neo4j.gds.config.UserInputAsStringOrListOfString` is using
+    //  - Node
+    //  - Relationship
+    //  - Path
+    // TODO: Move UserInputAsStringOrListOfString up where it belongs
+    compileOnly(
+        [group: 'org.neo4j', name: 'neo4j-graphdb-api', version: ver.'neo4j'],
+    )
+
     api openGds.commons.lang3
+
+    implementation(
+        project(':concurrency'),
+        project(':concurrency-validation-api'),
+        project(':core-api'),
+        project(':graph-projection-api'),
+        project(':graph-schema-api'),
+        // `JobIdConfig` 🙈
+        project(':progress-tracking'),
+        project(':string-formatting'),
+    )
 }

core/src/main/java/org/neo4j/gds/config/AlgoBaseConfig.java renamed to config-api/src/main/java/org/neo4j/gds/config/AlgoBaseConfig.java

@@ -23,6 +23,7 @@
 import org.neo4j.gds.NodeLabel;
 import org.neo4j.gds.api.GraphStore;
 import org.neo4j.gds.api.IdMap;
+import org.neo4j.gds.utils.StringFormatting;
 import org.neo4j.gds.utils.StringJoining;
 
 import java.util.Collection;
@@ -72,7 +73,7 @@ static void nodesExistInGraph(
             .collect(Collectors.toList());
 
         if (!missingNodes.isEmpty()) {
-            throw new IllegalArgumentException(formatWithLocale(
+            throw new IllegalArgumentException(StringFormatting.formatWithLocale(
                 "%s nodes do not exist in the in-memory graph%s: %s",
                 parameterKey,
                 nodeLabelFilterDescription(filteredNodeLabels, graphStore),
@@ -88,7 +89,7 @@ public static void validateNodePropertyExists(
         @Nullable String propertyName
     ) {
         if (graphStore.hasNodeProperty(nodeLabels, propertyName)) return;
-        throw new IllegalArgumentException(formatWithLocale(
+        throw new IllegalArgumentException(StringFormatting.formatWithLocale(
             "%s `%s` not found in graph with node properties: %s",
             configKey,
             propertyName,