Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS failures / false positives #5

Open
roccoblues opened this issue Aug 21, 2023 · 2 comments
Open

macOS failures / false positives #5

roccoblues opened this issue Aug 21, 2023 · 2 comments

Comments

@roccoblues
Copy link
Member

roccoblues commented Aug 21, 2023

Full list of errors I currently get. Created with:

find . \( -name .git -o -name queue.h -o -path './test/*' -o -path './autosetup/*' -o -path './docs/*' \) -prune -o -type f -name '*.[ch]' -print | sed 's/^\.\///' | sort | xargs ../iwyu/bin/iwyu.sh

Some of those are definitely related to my setup. For example I don't build with rocksdb or notmuch:

grep -ri fatal /tmp/iwyu.txt | perl -pe 's/.*: fatal/fatal/' | sort | uniq
/tmp/iwyu.txt:fatal error: too many errors emitted, stopping now [-ferror-limit=]
fatal error: 'depot.h' file not found
fatal error: 'gdbm.h' file not found
fatal error: 'gnutls/gnutls.h' file not found
fatal error: 'gpg-error.h' file not found
fatal error: 'gpgme.h' file not found
fatal error: 'gsasl.h' file not found
fatal error: 'idn2.h' file not found
fatal error: 'kclangc.h' file not found
fatal error: 'lauxlib.h' file not found
fatal error: 'libintl.h' file not found
fatal error: 'lmdb.h' file not found
fatal error: 'lz4.h' file not found
fatal error: 'notmuch.h' file not found
fatal error: 'openssl/asn1.h' file not found
fatal error: 'rocksdb/c.h' file not found
fatal error: 'sys/inotify.h' file not found
fatal error: 'tcbdb.h' file not found
fatal error: 'tdb.h' file not found
fatal error: 'zstd.h' file not found

Tooling

❯ $CC --version
Homebrew clang version 16.0.6
Target: arm64-apple-darwin22.6.0
Thread model: posix
InstalledDir: /opt/homebrew/Cellar/llvm/16.0.6/bin

❯ $IWYU --version
include-what-you-use 0.20 based on Homebrew clang version 16.0.6

iwyu.txt

@flatcap
Copy link
Member

flatcap commented Aug 21, 2023

That actually doesn't look too bad.
Excluding the not-installed stuff, there look to be a few more sys/ fixes.

How does it look if you just check the files that you actually build?
(assuming you don't want to install every possible feature)

@roccoblues
Copy link
Member Author

#6 and https://github.com/neomutt/neomutt/tree/devel/iwyu improved this a lot:

iwyu.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants