Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast API on CPU + MPS GPU #658

Open
fakerybakery opened this issue Oct 28, 2023 · 6 comments
Open

Fast API on CPU + MPS GPU #658

fakerybakery opened this issue Oct 28, 2023 · 6 comments

Comments

@fakerybakery
Copy link
Contributor

fakerybakery commented Oct 28, 2023

Hi @manmay-nakhashi, are you planning to support the fast API work on CPU + MPS GPU? Thanks!

@fakerybakery
Copy link
Contributor Author

Just realized this can't work on MPS since the fast API requires autocast and autocast isn't yet supported on MPS. I guess we'll have to wait for that to get merged before the fast API will work

@SSardorf
Copy link

SSardorf commented Dec 18, 2024

pytorch/pytorch#99272 (comment) Seems autocast is finally supported on MPS!

@SSardorf
Copy link

SSardorf commented Dec 18, 2024

I made some changes to the codebase, which lets it utilize mps when running autocast, and based on some initial testing, it's significantly faster. Especially on the clvp step!

@fakerybakery @manmay-nakhashi
CleanShot 2024-12-18 at 12 59 11@2x

@manmay-nakhashi
Copy link
Collaborator

@SSardorf can you make pull request for this ?

@SSardorf
Copy link

@SSardorf can you make pull request for this ?

Sure, I'll clean up the changes and open a PR 👍

@SSardorf
Copy link

Opened a draft PR. There may be other places where mps could help, I just haven't had a chance to look
#837

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants