Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons to big in conflict dialog okay: #3882

Open
mhsdesign opened this issue Nov 9, 2024 · 0 comments
Open

Icons to big in conflict dialog okay: #3882

mhsdesign opened this issue Nov 9, 2024 · 0 comments

Comments

@mhsdesign
Copy link
Member

is:

image

wanted:

image

Related #3861

markusguenther added a commit to markusguenther/neos-ui that referenced this issue Feb 4, 2025
The icons have multiple classes. From Font Awesome, we obtain the custom replacement class neos-svg-inline—fa, which sets a height of 1rem. However, we define the selectBoxHeaderWithSearchInput__icon class and set the height to 40px via a variable. The issue arises because the order in which these classes are applied determines the winning height. In Neos 8.4, the 40px height prevails, while in Neos 9.0, the 1rem height takes precedence. Consequently, the icons appear misaligned.

To address this issue, we implement an adjustment that ensures that when an element possesses both of these classes, the height of 40px from our custom class prevails.

Related: neos#3882
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant