Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Reviewer for Datamapper #28

Open
arkiver opened this issue May 6, 2013 · 2 comments
Open

Query Reviewer for Datamapper #28

arkiver opened this issue May 6, 2013 · 2 comments

Comments

@arkiver
Copy link

arkiver commented May 6, 2013

I am using MySql and Datamapper on a Rails 3.2.11 app. Was trying to use query reviewer but getting this error on server start:

.rvm/gems/ruby-1.9.3-p194@bookings/gems/query_reviewer-0.1.8/lib/query_reviewer/rails.rb:6:in `inject_reviewer': uninitialized constant QueryReviewer::ActiveRecord (NameError)

I guess query reviewer does not support DataMapper yet ? Let me know if you would prefer a full stack trace.

@arkiver
Copy link
Author

arkiver commented May 6, 2013

If datamapper is not supported, with some guidance, I will try to add code to support datamapper as well.

@nesquena
Copy link
Owner

nesquena commented May 6, 2013

You are right currently query reviewer has certain expectations of active record. I'd love for a future version to support any activemodel compliant orm. If you are interested in helping add datamapper support I suspect it wouldn't be too difficult. 

Nathan Esquenazi
CodePath Co-founder
http://thecodepath.com

On Mon, May 6, 2013 at 5:04 PM, Akshay Khole [email protected]
wrote:

If datamapper is not supported, with some guidance, I will try to add code to support datamapper as well.

Reply to this email directly or view it on GitHub:
#28 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants