Skip to content

Commit

Permalink
fix: patch vm2 Sandbox Escape vulnerability
Browse files Browse the repository at this point in the history
  • Loading branch information
@juandav
juandav committed Jul 20, 2023
1 parent 02cc7a9 commit 0f89a36
Show file tree
Hide file tree
Showing 5 changed files with 61 additions and 56 deletions.
3 changes: 3 additions & 0 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -102,5 +102,8 @@
"handlebars": "^4.7.6",
"nodemailer": "^6.4.6",
"pug": "^3.0.1"
},
"resolutions": {

This comment has been minimized.

Sign in to view

Copy link
@pharindoko

pharindoko Aug 21, 2023

@juandav
this only fixes it for yarn as I understood ...
Seems like overrides work for npm:
https://docs.npmjs.com/cli/v9/configuring-npm/package-json#overrides

This comment has been minimized.

Sign in to view

Copy link
@poojakharel

poojakharel Aug 30, 2023

will this be addressed for npm as well soon?
"vm2": "isolated-vm"
}
}
3 changes: 2 additions & 1 deletion sample/01-basic/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ Synchronous import
```javascript
//app.module.ts
import { Module } from '@nestjs/common';
import { HandlebarsAdapter, MailerModule } from '@nestjs-modules/mailer';
import { MailerModule } from '@nestjs-modules/mailer';
import { HandlebarsAdapter } from '@nestjs-modules/mailer/adapters/handlebars.adapter';

@Module({
imports: [
Expand Down
54 changes: 27 additions & 27 deletions sample/01-basic/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,36 +21,36 @@
},
"dependencies": {
"@nestjs-modules/mailer": "../../dist",
"@nestjs/common": "8.2.4",
"@nestjs/core": "8.2.4",
"@nestjs/platform-express": "8.2.4",
"dotenv": "10.0.0",
"nodemailer": "6.7.2",
"@nestjs/common": "10.1.0",
"@nestjs/core": "10.1.0",
"@nestjs/platform-express": "10.1.0",
"dotenv": "16.3.1",
"nodemailer": "6.9.4",
"reflect-metadata": "0.1.13",
"rimraf": "3.0.2",
"rxjs": "7.4.0"
"rimraf": "5.0.1",
"rxjs": "7.8.1"
},
"devDependencies": {
"@nestjs/cli": "8.1.6",
"@nestjs/schematics": "8.0.5",
"@nestjs/testing": "8.2.4",
"@types/express": "4.17.13",
"@types/jest": "26.0.24",
"@types/node": "16.11.17",
"@types/supertest": "2.0.11",
"@typescript-eslint/eslint-plugin": "5.8.0",
"@typescript-eslint/parser": "5.8.0",
"eslint": "8.5.0",
"eslint-config-prettier": "8.3.0",
"eslint-plugin-import": "2.23.4",
"jest": "27.0.6",
"prettier": "2.3.2",
"supertest": "6.1.6",
"ts-jest": "27.1.2",
"ts-loader": "9.2.3",
"ts-node": "10.4.0",
"tsconfig-paths": "3.11.0",
"typescript": "4.3.5"
"@nestjs/cli": "10.1.10",
"@nestjs/schematics": "10.0.1",
"@nestjs/testing": "10.1.0",
"@types/express": "4.17.17",
"@types/jest": "29.5.3",
"@types/node": "20.4.2",
"@types/supertest": "2.0.12",
"@typescript-eslint/eslint-plugin": "6.1.0",
"@typescript-eslint/parser": "6.1.0",
"eslint": "8.45.0",
"eslint-config-prettier": "8.8.0",
"eslint-plugin-import": "2.27.5",
"jest": "29.6.1",
"prettier": "3.0.0",
"supertest": "6.3.3",
"ts-jest": "29.1.1",
"ts-loader": "9.4.4",
"ts-node": "10.9.1",
"tsconfig-paths": "4.2.0",
"typescript": "5.1.6"
},
"jest": {
"moduleFileExtensions": [
Expand Down
3 changes: 2 additions & 1 deletion sample/01-basic/src/app.module.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ require('dotenv').config();
import { Module } from '@nestjs/common';
import { AppController } from './app.controller';
import { AppService } from './app.service';
import { HandlebarsAdapter, MailerModule } from '@nestjs-modules/mailer';
import { MailerModule } from '@nestjs-modules/mailer/';
import { HandlebarsAdapter } from '@nestjs-modules/mailer/adapters/handlebars.adapter';

@Module({
imports: [
Expand Down
54 changes: 27 additions & 27 deletions sample/02-custom-template-adapter/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,36 +22,36 @@
},
"dependencies": {
"@nestjs-modules/mailer": "../../dist",
"@nestjs/common": "8.2.4",
"@nestjs/core": "8.2.4",
"@nestjs/platform-express": "8.2.4",
"nodemailer": "6.7.2",
"@nestjs/common": "10.1.0",
"@nestjs/core": "10.1.0",
"@nestjs/platform-express": "10.1.0",
"nodemailer": "6.9.4",
"reflect-metadata": "0.1.13",
"rimraf": "3.0.2",
"rxjs": "7.4.0",
"twing": "5.1.0"
"rimraf": "5.0.1",
"rxjs": "7.8.1",
"twing": "5.1.4"
},
"devDependencies": {
"@nestjs/cli": "8.1.6",
"@nestjs/schematics": "8.0.5",
"@nestjs/testing": "8.2.4",
"@types/express": "4.17.13",
"@types/jest": "26.0.24",
"@types/node": "16.11.17",
"@types/supertest": "2.0.11",
"@typescript-eslint/eslint-plugin": "5.8.0",
"@typescript-eslint/parser": "5.8.0",
"eslint": "8.5.0",
"eslint-config-prettier": "8.3.0",
"eslint-plugin-import": "2.23.4",
"jest": "27.0.6",
"prettier": "2.3.2",
"supertest": "6.1.6",
"ts-jest": "27.1.2",
"ts-loader": "9.2.3",
"ts-node": "10.4.0",
"tsconfig-paths": "3.11.0",
"typescript": "4.3.5"
"@nestjs/cli": "10.1.10",
"@nestjs/schematics": "10.0.1",
"@nestjs/testing": "10.1.0",
"@types/express": "4.17.17",
"@types/jest": "29.5.3",
"@types/node": "20.4.2",
"@types/supertest": "2.0.12",
"@typescript-eslint/eslint-plugin": "6.1.0",
"@typescript-eslint/parser": "6.1.0",
"eslint": "8.45.0",
"eslint-config-prettier": "8.8.0",
"eslint-plugin-import": "2.27.5",
"jest": "29.6.1",
"prettier": "3.0.0",
"supertest": "6.3.3",
"ts-jest": "29.1.1",
"ts-loader": "9.4.4",
"ts-node": "10.9.1",
"tsconfig-paths": "4.2.0",
"typescript": "5.1.6"
},
"jest": {
"moduleFileExtensions": [
Expand Down

0 comments on commit 0f89a36

Please sign in to comment.