-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.11 breaks backward compatibility #1127
Comments
Yea I can confirm this. Upon updating 1.11.2 i get the following error upon startup: |
I can confirm too, my application used SendMailTransport and I received the same errors. I removed it to use simple object config and I discovered the same error message that @domme1908 referred (see comment above ↑) |
Why I always receiving |
Me too, please tell me how to solve it? |
About the phantom Lines 113 to 114 in fce9695
Since |
Fixed in this PR #1133. Sorry for this inconvenience, I had indeed run npm run test but not with SendGrid. Now, the test has become "optional," and I have added an additional check just in case. |
Describe the bug
After upgrading to 1.11 or later it faills compilation while using either 'nodemailer-mandrill-transport' or 'nodemailer-mailgun-transport'.
To Reproduce
Expected behavior
It should not break compatibility with older transports that use callbacks intead of promises
Additional context
The text was updated successfully, but these errors were encountered: