Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tslib dependency at runtime #1230

Open
mbiegert opened this issue Aug 6, 2024 · 0 comments
Open

Tslib dependency at runtime #1230

mbiegert opened this issue Aug 6, 2024 · 0 comments

Comments

@mbiegert
Copy link

mbiegert commented Aug 6, 2024

This seems to be somewhat of a followup to #849. There the issue was supposedly fixed with adding tslib to the dependencies. However it was added to the "devDependencies", however it appears to should have been added to the regular "dependencies" list. When using the pnp mode of yarn in my project which depends on "@nestjs-modules/mailer@^2.0.2" I receive the following error on starting nest:

Error: @nestjs-modules/mailer tried to access tslib, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

The following yarn packageExtension fixes this:

  "@nestjs-modules/mailer@^2.0.0": {
    dependencies: {
      # This is the version of tslib they declare in their devDependencies
      tslib: "2.6.2"
    }
  }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant