From ecceed9c201a8f060cba81ef5da365be53edeaad Mon Sep 17 00:00:00 2001 From: Jessica Mitchell Date: Thu, 27 Jun 2024 13:07:39 +0200 Subject: [PATCH 1/4] add deprecation notice to mc models --- models/iaf_cond_alpha_mc.h | 6 +++++- models/pp_cond_exp_mc_urbanczik.h | 5 +++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/models/iaf_cond_alpha_mc.h b/models/iaf_cond_alpha_mc.h index 41f93eeb38..4262c0935e 100644 --- a/models/iaf_cond_alpha_mc.h +++ b/models/iaf_cond_alpha_mc.h @@ -68,10 +68,14 @@ Short description Multi-compartment conductance-based leaky integrate-and-fire neuron model - Description +++++++++++ +.. admonition:: Deprecated model + + ``iaf_cond_alpha_mc`` is deprecated because cm_default is an improved + implementation of compartmental models in NEST (see :doc:`cm_default`). + THIS MODEL IS A PROTOTYPE FOR ILLUSTRATION PURPOSES. IT IS NOT YET FULLY TESTED. USE AT YOUR OWN PERIL! diff --git a/models/pp_cond_exp_mc_urbanczik.h b/models/pp_cond_exp_mc_urbanczik.h index e9507d0781..41d3ea7a8d 100644 --- a/models/pp_cond_exp_mc_urbanczik.h +++ b/models/pp_cond_exp_mc_urbanczik.h @@ -115,6 +115,11 @@ Two-compartment point process neuron with conductance-based synapses Description +++++++++++ +.. admonition:: Deprecated model + + ``pp_cond_exp_mc_urbanczik`` is deprecated because cm_default is an improved + implementation of compartmental models in NEST (see :doc:`cm_default`). + pp_cond_exp_mc_urbanczik is an implementation of a two-compartment spiking point process neuron with conductance-based synapses as it is used in [1]_. It is capable of connecting to an :doc:`Urbanczik synapse From 72d86f97b6333fc7fef6b7858fa23c97e7ea778f Mon Sep 17 00:00:00 2001 From: jessica-mitchell Date: Thu, 27 Jun 2024 13:12:14 +0200 Subject: [PATCH 2/4] Apply suggestions from code review --- models/iaf_cond_alpha_mc.h | 2 +- models/pp_cond_exp_mc_urbanczik.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/models/iaf_cond_alpha_mc.h b/models/iaf_cond_alpha_mc.h index 4262c0935e..0e964cd7e4 100644 --- a/models/iaf_cond_alpha_mc.h +++ b/models/iaf_cond_alpha_mc.h @@ -73,7 +73,7 @@ Description .. admonition:: Deprecated model - ``iaf_cond_alpha_mc`` is deprecated because cm_default is an improved + ``iaf_cond_alpha_mc`` is deprecated because ``cm_default`` is an improved implementation of compartmental models in NEST (see :doc:`cm_default`). THIS MODEL IS A PROTOTYPE FOR ILLUSTRATION PURPOSES. IT IS NOT YET diff --git a/models/pp_cond_exp_mc_urbanczik.h b/models/pp_cond_exp_mc_urbanczik.h index 41d3ea7a8d..32ea2382d6 100644 --- a/models/pp_cond_exp_mc_urbanczik.h +++ b/models/pp_cond_exp_mc_urbanczik.h @@ -117,7 +117,7 @@ Description .. admonition:: Deprecated model - ``pp_cond_exp_mc_urbanczik`` is deprecated because cm_default is an improved + ``pp_cond_exp_mc_urbanczik`` is deprecated because ``cm_default`` is an improved implementation of compartmental models in NEST (see :doc:`cm_default`). pp_cond_exp_mc_urbanczik is an implementation of a two-compartment spiking From 39e8f84802f4432ace429deffc0e13fdd5f6fcf8 Mon Sep 17 00:00:00 2001 From: jessica-mitchell Date: Thu, 27 Jun 2024 13:26:12 +0200 Subject: [PATCH 3/4] Apply suggestions from code review --- models/iaf_cond_alpha_mc.h | 2 +- models/pp_cond_exp_mc_urbanczik.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/models/iaf_cond_alpha_mc.h b/models/iaf_cond_alpha_mc.h index 0e964cd7e4..ab67638f4e 100644 --- a/models/iaf_cond_alpha_mc.h +++ b/models/iaf_cond_alpha_mc.h @@ -74,7 +74,7 @@ Description .. admonition:: Deprecated model ``iaf_cond_alpha_mc`` is deprecated because ``cm_default`` is an improved - implementation of compartmental models in NEST (see :doc:`cm_default`). + implementation of compartmental models in NEST (see :doc:`cm_default`). THIS MODEL IS A PROTOTYPE FOR ILLUSTRATION PURPOSES. IT IS NOT YET FULLY TESTED. USE AT YOUR OWN PERIL! diff --git a/models/pp_cond_exp_mc_urbanczik.h b/models/pp_cond_exp_mc_urbanczik.h index 32ea2382d6..e41d5b7623 100644 --- a/models/pp_cond_exp_mc_urbanczik.h +++ b/models/pp_cond_exp_mc_urbanczik.h @@ -118,7 +118,7 @@ Description .. admonition:: Deprecated model ``pp_cond_exp_mc_urbanczik`` is deprecated because ``cm_default`` is an improved - implementation of compartmental models in NEST (see :doc:`cm_default`). + implementation of compartmental models in NEST (see :doc:`cm_default`). pp_cond_exp_mc_urbanczik is an implementation of a two-compartment spiking point process neuron with conductance-based synapses as it is used From cbcbc21d53c6e6d05abeeafae129f1ff907891ee Mon Sep 17 00:00:00 2001 From: Jessica Mitchell Date: Wed, 31 Jul 2024 21:48:13 +0200 Subject: [PATCH 4/4] remove deprecation notice for urbanczik --- models/pp_cond_exp_mc_urbanczik.h | 5 ----- 1 file changed, 5 deletions(-) diff --git a/models/pp_cond_exp_mc_urbanczik.h b/models/pp_cond_exp_mc_urbanczik.h index 41d3ea7a8d..e9507d0781 100644 --- a/models/pp_cond_exp_mc_urbanczik.h +++ b/models/pp_cond_exp_mc_urbanczik.h @@ -115,11 +115,6 @@ Two-compartment point process neuron with conductance-based synapses Description +++++++++++ -.. admonition:: Deprecated model - - ``pp_cond_exp_mc_urbanczik`` is deprecated because cm_default is an improved - implementation of compartmental models in NEST (see :doc:`cm_default`). - pp_cond_exp_mc_urbanczik is an implementation of a two-compartment spiking point process neuron with conductance-based synapses as it is used in [1]_. It is capable of connecting to an :doc:`Urbanczik synapse