Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STDP Tests Spike Time Mismatch #3250

Open
otcathatsya opened this issue Jul 12, 2024 · 2 comments
Open

STDP Tests Spike Time Mismatch #3250

otcathatsya opened this issue Jul 12, 2024 · 2 comments
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority stale Automatic marker for inactivity, please have another look here T: Maintenance Work to keep up the quality of the code and documentation.

Comments

@otcathatsya
Copy link
Contributor

In the older pytests for STDP synapses (e.g. test_stdp_pl_synapse_hom.py, test_stdp_synapse.py) hard-coded spike times are fed to alpha psc neurons, whose spike output is then used for a manual reproduction of the weight drift & subsequently compared. The issue is that, due to the nature of the alpha neurons and the high weights set from generators to neuron populations, many of the hardcoded times (and therefore potential corner cases for testing) end up ignored.

@terhorstd terhorstd added S: Normal Handle this with default priority T: Maintenance Work to keep up the quality of the code and documentation. I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) labels Jul 24, 2024
@terhorstd
Copy link
Contributor

This may be related to #2168 . If so, please close here and bring this into the discussion there.

Copy link

Issue automatically marked stale!

@github-actions github-actions bot added the stale Automatic marker for inactivity, please have another look here label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: No breaking change Previously written code will work as before, no one should note anything changing (aside the fix) S: Normal Handle this with default priority stale Automatic marker for inactivity, please have another look here T: Maintenance Work to keep up the quality of the code and documentation.
Projects
None yet
Development

No branches or pull requests

2 participants